[Nut-upsdev] resending patch

[Arnaud Quette]

2006/7/7, Peter Selinger <selinger at mathstat.dal.ca>:
>
> Hi Silvino,
>
> thanks for your work on this driver. Are you sure the new patch is in
> English?


in fact, it's in english for solis but not for rhino.
I've fixed the latter and included it in Testing for 2.0.4-pre2.

Some more comments and questions:
- I've got a link error with rhino on « pow ». I've modified gendb to
include "-lm" (link against libmath)...
- outlet.0 is equal to ups. The first real outlet is outlet1...
are you sure about your outlet0
- the values for outlet.* are lower case (ie Yes/No => yes/no). Also fixed.
- can't rhino and solis drivers be merged (into ie a microsol driver),
including some protocol detection mechanism or switch parameter? The more
shared code and the less driver, the better,
- avoid "printf" and prefer either upsdebug/upsdebugx instead,
- avoid malloc() and prefer xmalloc()
=> more generally, check
http://eu1.networkupstools.org/doc/2.0.1/developers.html
- as told previously, prefer english comments and variables name. That make
life easier for maintainers and contributors.

Please, check for correcting all these when you have a bit of time. After
that, we'll be able to check for joining the team ;-)

Arnaud
-- 
Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
<http://people.debian.org/%7Eaquette/>
OpenSource Developer - http://arnaud.quette.free.fr/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20060710/635b191a/attachment.htm