[Nut-upsdev] Re: [nut-commits] svn commit r801 - in branches/megatec-usb: . drivers

[Jon Gough]

Peter,
    Yep, at the moment the Krauler driver works OK for me. So if you 
want to make the change that is fine.

Regards
   Jon

At 03:42 9/02/2007, Peter Selinger wrote:
>Hi Alexander,
>
>thanks for your good work on the megatec_usb driver. I have made a few
>more (cosmetic) changes.
>
>Is the driver now working stably for your device? In particular, do
>the instant commands (and particularly "upsdrvctl -k") work properly?
>In this case, we could hopefully mark the device as "supported" and
>merge the driver to the main branch.
>
>There is still the question of whether to keep separate code for
>Ablerex and Krauler. From what I understand, each of these subdrivers
>works for each of the devices. But the Krauler driver is now more
>advanced (with the retry feature), so we could remove the Ablerex
>subdriver (provided Jon tests the Krauler one to make sure it still
>works for the Ablerex device).
>
>If I understand correctly, the only change needed would be to change
>
>    {0xffff, 0x0000, get_data_ablerex, set_data_ablerex},
>
>to
>
>    {0xffff, 0x0000, get_data_krauler, set_data_krauler},
>
>is that correct? -- Peter
>
>Alexander Gordeev wrote:
> >
> > Author: agordeev-guest
> > Date: Thu Feb  8 16:43:43 2007
> > New Revision: 801
> >
> > Modified:
> >    branches/megatec-usb/ChangeLog
> >    branches/megatec-usb/drivers/megatec_usb.c
> > Log:
> > - drivers/megatec_usb.c: fixed the problem with report descriptor 
> retrieval at driver startups which caused failures. Since none of 
> the subdrivers needs this descriptor it isn't retrieved at all.
> >
> >
> > Modified: branches/megatec-usb/ChangeLog
> > 
> ==============================================================================
> > --- branches/megatec-usb/ChangeLog    (original)
> > +++ branches/megatec-usb/ChangeLog    Thu Feb  8 16:43:43 2007
> > @@ -1,3 +1,9 @@
> > +Thu Feb  8 15:43:00 UTC 2007 / Alexander I. Gordeev 
> <lasaine at lvk.cs.msu.su>
> > +
> > + - drivers/megatec_usb.c: fixed the problem with report descriptor
> > +   retrieval at driver startups which caused failures. Since none of the
> > +   subdrivers needs this descriptor it isn't retrieved at all.
> > +
> >  Thu Feb  8 15:26:37 UTC 2007 / Alexander I. Gordeev 
> <lasaine at lvk.cs.msu.su>
> >
> >   - drivers/megatec_usb.c: fixed "UPS No Ack" issue and optimized
> >
> > Modified: branches/megatec-usb/drivers/megatec_usb.c
> > 
> ==============================================================================
> > --- branches/megatec-usb/drivers/megatec_usb.c        (original)
> > +++ branches/megatec-usb/drivers/megatec_usb.c        Thu Feb  8 
> 16:43:43 2007
> > @@ -152,7 +152,7 @@
> >          }
> >      }
> >
> > -    ret = usb->open(&udev,&hiddevice,&match,u.report_desc,MODE_OPEN);
> > +    ret = usb->open(&udev,&hiddevice,&match,u.report_desc,MODE_REOPEN);
> >      if (ret<0)
> >          usb_open_error(port);
> >
> >
> > _______________________________________________
> > nut-commits mailing list
> > nut-commits at lists.alioth.debian.org
> > http://lists.alioth.debian.org/mailman/listinfo/nut-commits
> >




---
avast! Antivirus: Outbound message clean.
Virus Database (VPS): 000712-1, 08/02/2007
Tested on: 9/02/2007 5:04:20 AM
avast! is copyright (c) 2000-2007 ALWIL Software.
http://www.avast.com


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20070209/4b1a0e16/attachment.htm