[Nut-upsdev] Re: [nut-commits] svn commit r716 - in trunk: . drivers

[Peter Selinger]

Arnaud,

you changed the "if" part, perhaps you'd like to change the "else"
part, too?

Changing the output format of HIDDumpTree() has the potential to break
the functionality of scripts/subdriver/path-to-subdriver.sh; I don't
think it does in this instance, but I have not checked it. Perhaps it
would be good to add a comment in the source code as a caution.

-- Peter

Arnaud Quette wrote:
> 
> Author: aquette
> Date: Mon Jan  8 10:52:18 2007
> New Revision: 716
> 
> Modified:
>    trunk/ChangeLog
>    trunk/drivers/libhid.c
> Log:
> HIDDumpTree() also prints the data ReportID, Offset and Size
> 
> Modified: trunk/ChangeLog
> ==============================================================================
> --- trunk/ChangeLog	(original)
> +++ trunk/ChangeLog	Mon Jan  8 10:52:18 2007
> @@ -1,3 +1,7 @@
> +Mon Jan  8 00:52:51 UTC 2007 / Arnaud Quette <aquette.dev at gmail.com>
> +
> + - libhid.c: HIDDumpTree() also prints the data ReportID, Offset and Size.
> +
>  Mon Jan  8 00:52:51 UTC 2007 / Peter Selinger <selinger at users.sourceforge.net>
>  
>   - autoconf: removed test for s6_addr32, added test for IN6_IS_ADDR_V4MAPPED.
> 
> Modified: trunk/drivers/libhid.c
> ==============================================================================
> --- trunk/drivers/libhid.c	(original)
> +++ trunk/drivers/libhid.c	Mon Jan  8 10:52:18 2007
> @@ -561,8 +561,9 @@
>  
>  			/* Get data value */
>  			if (HIDGetItemValue(udev, path, &value, utab) > 0)
> -				upsdebugx(1, "Path: %s, Type: %s, Value: %f", path, type, value);
> -			
> +				upsdebugx(1, "Path: %s, Type: %s, ReportID: 0x%02x, Offset: %i, Size: %i, Value: %f",
> +				  path, type, pData->ReportID, pData->Offset, pData->Size, value);
> +
>  			else
>  				upsdebugx(1, "Path: %s, Type: %s", path, type);
>  		}
> 
> _______________________________________________
> nut-commits mailing list
> nut-commits at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-commits
>