[Nut-upsdev] Re: [nut-commits] svn commit r716 - in trunk: . drivers

[Peter Selinger]

Excellent, thanks! -- Peter

Arnaud Quette wrote:
> 
> 2007/1/8, Peter Selinger <selinger at mathstat.dal.ca>:
> > Arnaud,
> >
> > you changed the "if" part, perhaps you'd like to change the "else"
> > part, too?
> 
> good point. fixed in r727, thanks
> 
> > Changing the output format of HIDDumpTree() has the potential to break
> > the functionality of scripts/subdriver/path-to-subdriver.sh; I don't
> > think it does in this instance, but I have not checked it. Perhaps it
> > would be good to add a comment in the source code as a caution.
> 
> I've quickly tried it (for the 1rst time ; it's really a good tool),
> and it seems to work.
> Anyway, I've added a comment in DumpTree() since breaking the output
> format can lead to path-to-subdriver.sh breakage.
> 
> Note that I've updated a bit the script for the "do not forget to"
> section, following the automake switch.
> 
> > Arnaud Quette wrote:
> > >
> > > Author: aquette
> > > Date: Mon Jan  8 10:52:18 2007
> > > New Revision: 716
> > >
> > > Modified:
> > >    trunk/ChangeLog
> > >    trunk/drivers/libhid.c
> > > Log:
> > > HIDDumpTree() also prints the data ReportID, Offset and Size
> > >
> > > Modified: trunk/ChangeLog
> > >
> > ...
> 
> thanks,
> Arnaud
> -- 
> Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt
> Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
> Debian Developer - http://people.debian.org/~aquette/
> OpenSource Developer - http://arnaud.quette.free.fr/
>