[Nut-upsdev] tripplite_usb.c

Arjen de Korte nut+devel at de-korte.org
Thu Jun 21 13:05:12 UTC 2007


The same remarks as for the reconnect_ups() patch for usbhid-ups.c go for
the function with the same name in tripplite_usb.c. This is also blocking
and thereby locking up the communication between driver and server. I
don't think this is intentional, since the MAX_RECONNECT_TRIES in
usb_comm_fail() is effectively a no-op then. I also seems to duplicate
some things in usb_comm_fail(), like upsdrv_cleanup().

Best regards, Arjen
Eindhoven - The Netherlands
Key fingerprint - 66 4E 03 2C 9D B5 CB 9B  7A FE 7E C1 EE 88 BC 57

More information about the Nut-upsdev mailing list