[Nut-upsdev] USB support for Sweex 1000 VA UPS (was: Help with

[Peter Selinger]

Oops, sorry, I am reading the mailing list out of sync. I see that you
have already re-sent your patch. -- Peter

Peter Selinger wrote:
> 
> Hi Peter,
> 
> Alexander is right: your patch has been mangled by your email
> program. Lines have been broken; tabs have been changed to spaces, and
> the words "- Hide quoted text -" and "- Show quoted text -" have been
> inserted at random places. 
> 
> Patches must be machine-readable, so they can't be copy-and-pasted as
> text. Could you please re-send your patch as an attachment?
> 
> >From reading your patch, I noticed that you are using nut_usb.c for
> the USB access. That file is actually specifically for bcmxcp_usb.c,
> and applies only to Powerware devices. You should use the interface in
> libusb.c / libhid.c instead. See megatec_usb.c or tripplite_usb.c for
> how it is done.
> 
> Thanks, -- Peter
> 
> Peter van Valderen wrote:
> > 
> > Hello Arjen,
> > 
> > On 5/23/07, Arjen de Korte <nut+devel at de-korte.org> wrote:
> > > Never mind the above, but a more appropriate name might be
> > > 'genericups_usb', to indicate that it provides the same limited amount of
> > > monitoring and control.
> > 
> > Fair enough, I just had to come up with something when I was writing
> > it. I am now using it in combination with upsmon/upsd et al, it seems
> > to work alright.
> > 
> > Anyway, call it what you want, I don't mind.
> > 
> > Regards,
> > Peter
> > 
> > _______________________________________________
> > Nut-upsdev mailing list
> > Nut-upsdev at lists.alioth.debian.org
> > http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
> > 
> 
> 
> _______________________________________________
> Nut-upsdev mailing list
> Nut-upsdev at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
>