[Nut-upsdev] [nut-commits] svn commit r1376 - in trunk: . server

Arjen de Korte nut+devel at de-korte.org
Wed Apr 2 13:41:07 UTC 2008


>> By sorting this list alphabetically, you're removing the possibility to
>>  group commands logically. The 'calibrate.*' and 'test.*' commands are
>>  similar, so it is nice to list them as one group. By sorting commands
>>  alphabetically, the 'load.*' and 'shutdown.*' commands will be put in
>>  between them. This will look different for quite a few drivers.
> right. so the solution might be between, like using the order given in
> cmdvartab.

That would be an option, although it requires quite a bit of coding effort
to make this work. They will be added to the list in the server as they
are, but the server doesn't have a means to report the position of the
command in cmdvartab (so it can't give a preference value here). And also
note that the order of the commands in cmdvartab is currently still a mess
too, so this won't really help either.

> that allows both sorting and grouping smartly.
> note that this is just cosmetic, and not urging for 2.2.2...

Sorting might still be a good idea, since it will be easier to lookup in
the list if a command is used (you'd skip the remainder of the list if the
command you're looking for is already passed in the list).

Best regards, Arjen




More information about the Nut-upsdev mailing list