[Nut-upsdev] [nut-commits] svn commit r1296 - in trunk: . clients drivers server

[Arjen de Korte]

Charles Lepple wrote:

> Wow, that was quick... Thanks! (It was taking me a while to sort out
> all of the different CFLAGS settings; hence, the tracker item.)
> 
> I would take issue with the following assertion in Makefile.am:
> 
>   "In any case, CFLAGS are only -I options, so there is no harm."
> 
> since this is what got us into trouble in the first place... but I
> guess that was there before you edited it as well.

Yeah. I considered adding some words that adding CFLAGS may not be as
harmless as stated above. Maybe later.

> Here's the mess of flags from Net-SNMP on openSUSE, some of which seem
> to change the API somewhat:
> 
> "-DNETSNMP_ENABLE_IPV6 -O2 -march=i586 -mtune=i686 -fmessage-length=0
> -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -fno-strict-aliasing
> -fstack-protector-all -Ulinux -Dlinux=linux -I/usr/include/rpm
> -D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBUGGING
> -fno-strict-aliasing -pipe -Wdeclaration-after-statement
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -I/usr/lib/perl5/5.8.8/i586-linux-thread-multi/CORE -I.
> -I/usr/include"

That's indeed quite a bit and sure is worthy of leaving out if SNMP
support is not needed (or broken).

> At any rate, things seem to be working. Thanks again.

Do you think it is safe to backport r1296 and r1297 to Testing as well?

Best regards, Arjen