[Nut-upsdev] Bug#501087: nut: support for a tripplite avr750u

[Arnaud Quette]

2008/10/4 Arjen de Korte <nut+devel at de-korte.org>:
> Citeren Arnaud Quette <aquette.dev at gmail.com>:
>
>>> Attached is a patch adding "support" for tripplite's avr750u UPS.
>>> Issues:
>>> * productid still needs to be specified in ups.conf
>>
>> you missed to add an entry in drivers/tripplite-hid.c
>> ->tripplite_claim() for that ;-)
>
> And beware that you need to put it in the correct place as well. Some Tripp
> Lite HID devices (incorrectly) report battery voltage in decivolts so we
> need to apply a correction factor here. So there are basically two groups in
> this function. One that reports battery voltage in decivolts (productid
> 1003, 2005 and 2007) and one that reports battery voltage in volts
> (productid 3012, 4002, 4003). Before committing this change, we need to see
> the output of 'upsc' to know what it reports.

I missed that one. thanks for pointing it ;-)
@Raphael: would you be able to test a trunk version for fine tuning?

>> and an entry in the hotplug script for the sake of completion.
>
> Don't forget the udev and hal scripts either. We probably need to come up
> with some automation here, so that we have to put this in only one place and
> have these scripts generated automagically.

I've thought about that, and have already done something similar for LIRC.
the base idea is to have something grep'able (like an empty USB_DEVICE
macro) and a defined format, like:
/* comment, like device vendor/name... */
USB_DEVICE(0x463, 0xffff)

thanks Arjen and Charles,
Arnaud
-- 
Linux / Unix Expert R&D - MGE Office Protection Systems - http://www.mgeops.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
Free Software Developer - http://arnaud.quette.free.fr/