[Nut-upsdev] patch for m4/nut_check_libwrap.m4

Arjen de Korte nut+devel at de-korte.org
Tue Dec 15 09:15:29 UTC 2009

Citeren Charles Lepple <clepple op gmail.com>:

>> I ran into some issues building nut-2.4.1 on my Solaris 10 machine.
>> Here is a patch for m4/nut_check_libwrap.m4 to fix libwrap support.


> let me know when you have had a chance to look at this (although I am
> tempted to just throw it in Buildbot and see what breaks).

I disagree. This patch makes too many assumptions on how libwrap  
support is implemented. We don't even come close to all different  
variations that exist in the field with our present set of BuildBots.

We have to rely in autoconf finding the proper includes and libraries  
here. What probably needs to be done is reordering some checks we do  
here and/or change from

     AC_CHECK_LIB(wrap, request_init, [], nut_have_libwrap=no)

to the preferred way (with possibly some additional search libraries)

     AC_SEARCH_LIBS(request_init, wrap, [], nut_have_libwrap=no)

We should really try to avoid using AC_TRY_LINK.

Best regards, Arjen
Please keep list traffic on the list

More information about the Nut-upsdev mailing list