[Nut-upsdev] [nut-commits] svn commit r1734 - in trunk/scripts: hal hotplug udev

[Arnaud Quette]

hey guys,

2009/1/15 Charles Lepple <clepple at gmail.com>

> On Thu, Jan 15, 2009 at 3:11 PM, Arjen de Korte <nut+devel at de-korte.org<nut%2Bdevel at de-korte.org>>
> wrote:
> >
> > Citeren Arjen de Korte <adkorte-guest at alioth.debian.org>:
> >
> > > Author: adkorte-guest
> > > Date: Thu Jan 15 20:02:22 2009
> > > New Revision: 1734
> > >
> > > Log:
> > > Freshly generated USB helper files
> > >
> > > Modified:
> > >    trunk/scripts/hal/ups-nut-device.fdi.in
> > >    trunk/scripts/hotplug/libhid.usermap
> > >    trunk/scripts/udev/nut-usbups.rules.in
> >
> > Questions is, should we try to keep these (generated) files up-to-date
> > in SVN as well, or is it better to svn:ignore them? The chance that
> > packagers don't have perl installed (and hence, won't be able to
> > generate them) is remote (automake won't run without it).
>
> As long as we are not using any special Perl modules, it shouldn't be
> an issue for developers (who would use automake anyway) to regenerate
> them.
>
> We might want to postpone the svn:ignore thing for a little while so
> we make sure we are tracking what versions of the files get released
> in 2.4.0 final. (As an aside, I still think we should do a bit of
> filtering so that the hotplug files do not automatically match bogus
> vendor IDs such as 0000, 0001, and ffff. Or at the very least, those
> vendor IDs should be in a separate file, to be installed in an
> optional package.)
>
> > Why are we generating this during 'make dist' and not just during
> > 'make' by the way? (ducking for cover)
>
> I would tend to agree that it would get tested more frequently if it
> were done during regular compilation.
>

fully agreeing!
the first step seems now mature, or about.
We're also not calling blindly the script, but pre testing for perl's
availability.
so the next stage (post 2.4.0 release) will be to move the call to the
standard build target.

about the filtering, I thought Arjen already applied the 2nd macro over
USB_DEVICE...

Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://www.eaton.com/mgeops
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://people.debian.org/~aquette/
Free Software Developer - http://arnaud.quette.free.fr/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20090116/879b9a4a/attachment.htm