[Nut-upsdev] [nut-commits] svn commit r1734 - in trunk/scripts: hal hotplug udev

[Arjen de Korte]

Citeren Arnaud Quette <aquette.dev at gmail.com>:

> about the filtering, I thought Arjen already applied the 2nd macro over
> USB_DEVICE...

Not yet, since I don't think we already reached a consensus on which  
devices should go into which script. Basically, there are three  
categories:

1) valid VID:PID that uniquely matches a UPS
2) valid VID:PID that uniquely matches a USB to serial converter
3) bogus VID:PID

Only for #1 there is no discussion that we can safely put this in the  
hotplug/udev/HAL scripts.

Regarding #2 and #3, it is questionable since a device showing up with  
this VID:PID combination *might* be a UPS, but it could also be  
something totally different. I know of at least one non-UPS device (a  
GPS) that uses a VID:PID combination that is in category #2. I don't  
think we should use these in the HAL script and I'm uncertain if it is  
a good idea to use it in the hotplug/udev scripts. Putting them in  
risks that we're setting the device up for NUT (while it is something  
else) and not putting them in will probably lead to many questions on  
the mailinglist why device X worked in nut-2.2.2 and no longer works  
for nut-2.4.0.

Best regards, Arjen
-- 
Please keep list traffic on the list