[Nut-upsdev] building on Solaris 10 (was Re: 2.4.2 freeze)

[Arjen de Korte]

Citeren Tim Rice <tim op multitalents.net>:

>> > "/opt/src/utils/nut-2.4.1-r2339/drivers/apcsmart.c", line 34:  
>> warning: too many struct/union initializers
> [...]
>>
>> Hopefully the preceding lines compiled properly - we use those
>> structures all over the place.
>
> It does compile.

I have my doubts here. I wouldn't be surprised if array declarations  
within structures with a length that needs to be computed by the  
compiler are not portable.

I'm also not convinced that we really need/can use this in the first  
place. At present, some drivers seem to print a message about the  
subdriver used here. In case of multiple subdrivers, we would first  
have to select the right subdriver and then the right subdrv_info  
element from the upsdrv_info. Since there is no fixed relation between  
the two (subdriver used and information about it in upsdrv_info), this  
is almost guaranteed to result in mismatches. I'd prefer to use the  
dstate_set/getinfo method for storing and retrieving this info.

Short of the above, I think the other warnings should be resolved now.  
Could you try to compile the latest version again on Solaris?

Best regards, Arjen
-- 
Please keep list traffic on the list