[Nut-upsdev] [RFC apcsmart V3 00/18] apcsmart driver updates

Michal Soltys soltys at ziu.info
Sat Mar 5 10:38:17 UTC 2011

Sorry for a bit longer delay than I anticipated, I was stuffed with the work.

This is the next iteration of the patch adding some functionality to apcsmart
driver, and relying on 'ignorelb' recently added.

Follow up from previous thread:


Main differences is that V3 is split into many small patches, so the reviewing
changes should be much easier. There're also a few additional changes in later

I'll do more tests in the following week, though everything seems to be working
fine so far. Still to do: manpage updates.

Michal Soltys (18):
  drivers/apcsmart.h: comsetics - adjust tabs and add basic modeline
  drivers/apcsmart.h: add compat hardware, add commands
  apcsmart: remove APC_IGNORE
  drivers/apcsmart.c: cosmetics
  drivers/apcsmart: adjust ignored chars and handle over/~over
  drivers/apcsmart.c: remove status_commit() from update_status()
  drivers/apcsmart: adjust how firmware_table_lookup() handles 'b' and 'V'
  drivers/dstate: add dstate_getflags()
  drivers/apcsmart: add APC_USERCTRL and APC_CRUCIAL
  drivers/apcsmart.c: add sdcmd_*() sdok()
  drivers/apcsmart.c: add upsdrv_shutdown_advanced() and upsdrv_shutdown_simple()
  drivers/apcsmart.c: adjust upsdrv_shutdown()
  drivers/apcsmart.c: update in-driver help information
  drivers/apcsmart.c: update version and authors
  drivers/apcsmart: remove CMD_IGN_CHARS
  drivers/apcsmart.c: don't overuse UPSDELAY
  drivers/apcsmart.c: add ser_flush_in() in setver_enum() and do_cmd()
  drivers/apcsmart: use STAT_INSTCMD_{HANDLED,FAILED} for sdcmd_*()

 drivers/apcsmart.c |  588 ++++++++++++++++++++++++++++++++++++++++------------
 drivers/apcsmart.h |   82 ++++---
 drivers/dstate.c   |    5 +
 drivers/dstate.h   |    1 +
 4 files changed, 510 insertions(+), 166 deletions(-)


More information about the Nut-upsdev mailing list