[Nut-upsdev] [RFC apcsmart V3 15/18] drivers/apcsmart: remove CMD_IGN_CHARS

Michal Soltys soltys at ziu.info
Sat Mar 5 10:38:32 UTC 2011


protocol_verify() only cares about explicitly specified commands
and variables.

Signed-off-by: Michal Soltys <soltys at ziu.info>
---
 drivers/apcsmart.c |    4 ----
 drivers/apcsmart.h |    3 ---
 2 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/apcsmart.c b/drivers/apcsmart.c
index d080a7d..0a6a56b 100644
--- a/drivers/apcsmart.c
+++ b/drivers/apcsmart.c
@@ -485,10 +485,6 @@ static void protocol_verify(unsigned char cmd)
 {
 	int	i, found, flags;
 
-	/* we might not care about this one */
-	if (strchr(CMD_IGN_CHARS, cmd))
-		return;
-
 	/* see if it's a variable */
 	for (i = 0; apc_vartab[i].name != NULL; i++) {
 
diff --git a/drivers/apcsmart.h b/drivers/apcsmart.h
index c85f76b..9862326 100644
--- a/drivers/apcsmart.h
+++ b/drivers/apcsmart.h
@@ -249,9 +249,6 @@ apc_cmdtab_t	apc_cmdtab[] =
 	{ NULL, 0, 0					}
 };
 
-/* things to ignore in protocol_verify - useless variables, etc. */
-#define CMD_IGN_CHARS "\032-78 at .,~\047\177QHRTYayz)1IJ"
-
 /* compatibility with hardware that doesn't do APC_CMDSET ('a') */
 
 struct {
-- 
1.7.2.1




More information about the Nut-upsdev mailing list