[Nut-upsdev] PowerCOM Driver Update

[Arnaud Quette]

2011/5/14 Keven L. Ates <atescomp at gmail.com>

> Arnaud,
>

Hi Keven,


> On May 13, 2011 8:21am, Arnaud Quette <aquette.dev at gmail.com> wrote:
> > I've just merged your patch (r2984), with just one change: the driver
> revision was already 0.12, since I've bumped to 0.13, along with your
> comment.
> > As a side note, could you please check to improve upsdrv_help() and
> upsdrv_makevartable() output.
> >
> > These should fit on a 80 column terminal, to ensure it is useful in all
> possible cases.
> >
> > This so needs some more formating, probably simplification and reference
> to the manual page.
>
> I reformatted these two support function as requested.  I also fixed
> up the powercom man page, but can't attest to its "man page"
> correctness.  The attached patch file has the fixes.
>

waow, awesome!
I'd like all contributions to be as complete and perfect as yours.

I've just committed it (r2990), with 2 minors fixes:
- added a comma before your name, in powercom.txt
- added a comment reference to upsdebug_hex(), l.371 in powercom.c. You may
want to look at it ;-)

a last question: would you be interested in becoming the official maintainer
for this driver?

thanks a lot.
Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20110519/507148d3/attachment.htm>