[Nut-upsdev] [PATCH] few additions to the nut-usbups.rules

Arnaud Quette aquette.dev at gmail.com
Thu Nov 3 14:53:18 UTC 2011


2011/11/3 Stanislav Brabec <sbrabec at suse.cz>

> Charles Lepple wrote:
> > On Nov 2, 2011, at 2:06 PM, Stanislav Brabec wrote:
>
> > IMHO, we only want NUT to claim these invalid USB IDs if the user
> > specifically requests it, rather than including it in the base NUT
> > distribution (think Gstreamer's "ugly" vs "good" plugins.)
>

indeed!
we previously included these buggy IDs, but was generating more general
issues than it was solving.


> > Arnaud, do you think it is worthwhile to split this off into a second
> > udev/hotplug configuration file? (I ask since I think either you or
> > someone else at Eaton wrote the script that generates the .rules.in
> > file).
>

yup, I did that automation to remove some more burden from our shoulders


> I cannot tell, what is better, not handle two strange UPSes by default
> and tell users what they should do, or add "daemon" group permission to
> a device with invalid id.
>
> (But the first will probably generate more bug reports.)
>

right, but you're only looking at it from the Suse point of view.
other distros handle these privileges differently, so sadly it's not a good
solution :(

I've been thinking a bit about that recently. part of the solution is
probably to:
- create another macro (BUGGY_USB_DEVICE) that consider these entries, but
add it as commented to the .rules file.
- find some way to bring users attention, like sys logging, graphical
notification, user manual notes or whatever.
- asking these users to bug report to the manufacturer may also help in
fixing the (future) situation.

One thing that may be the solution is to have more advanced rules for these
specific devices, that includes the device strings (manufacturer / device
name, ...) that would avoid false positive.
But before being able to do so, we'll need lsusb samples from such devices!

what is sure is that we still support these buggy devices and we'll
continue to do so.
but, we should only make it easier to these minority of users, and not
create trouble to the majority.
supporting buggy devices is one thing. Making it look like everything is
perfect under the sun is another!

cheers,
Arnaud
-- 
Linux / Unix Expert R&D - Eaton - http://powerquality.eaton.com
Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.free.fr/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20111103/8517b908/attachment.html>


More information about the Nut-upsdev mailing list