[Nut-upsdev] [PATCH 05/36] Document that this Makefile.am is broken by design.

Greg A. Woods woods at planix.com
Thu Mar 8 23:21:16 UTC 2012


From: "Greg A. Woods" <woods at planix.com>

---
 tools/Makefile.am |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/tools/Makefile.am b/tools/Makefile.am
index 0d9828b..88ee285 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -1,13 +1,31 @@
 # TODO: remove redundancies!
 
+# XXX this does not work with Automake!!!
+#
+# In fact the very concept is entirely antithetical to Automake.
+#
+# SUBDIRS are explicitly a listing of all the directories that make
+# must recurse into BEFORE processing the current directory.
+#
+# These python scripts must be moved into a sub-directory, and _only_
+# executed IFF they need to be, and all the nut-scanner sources need
+# to be moved out of a sub-directory into this directory.
+#
 # Force build in ./ before nut-scanner, to have nutscan-{usb,snmp}.h
 # built before going into the nut-scanner sub-directory
-SUBDIRS = . nut-scanner
+#
+#SUBDIRS = . nut-scanner
+SUBDIRS = nut-scanner
 
 EXTRA_DIST = nut-usbinfo.pl nut-hclinfo.py device-recorder.sh svn2cl.authors nut-snmpinfo.py
 
 all: nut-scanner-deps 
 
+# XXX these rules are all bogus!  They cause un-named target files to
+# always be rebuilt!  None of that is ever the right way to use make,
+# and especially not Automake.  Explicit filenames and their exact
+# dependencies need to be properly listed.
+
 nut-scanner-deps:
 	@if python -c 1; then \
 		echo "Regenerating the SNMP helper files."; \
-- 
1.7.9.2




More information about the Nut-upsdev mailing list