[Nut-upsdev] [nut-commits] svn commit r3603 - trunk/drivers

[Michal Soltys]

On 12-05-23 11:30, Arnaud Quette wrote:
> 2012/5/21 Arnaud Quette<aquette.dev at gmail.com>:
>>  2012/5/21 Charles Lepple<clepple at gmail.com>:
>>>  On May 16, 2012, at 10:10 AM, Arnaud Quette wrote:
>>>
>>>>  Author: aquette
>>>>  Date: Wed May 16 14:10:40 2012
>>>>  New Revision: 3603
>>>>  URL: http://trac.networkupstools.org/projects/nut/changeset/3603
>>>>
>>>>  Log:
>>>>  Final fix to the tcsetattr() / tcgetattr() issue
>>>
>>>
>>>  I propose reverting this commit for now, until we work in all of the autoconf magic to detect whether the various termio bits are present in the header files. (It failed to build on AIX, Solaris sparc+intel, and HPUX.)
>>
>>  yup, I've seen it lately over the long week end (which explains why
>>  I've not fixed it earlier...).
>>  I'll check if I can solve it properly and quickly, or will otherwise revert it...
>
> it turns out that there were not that many things missing to fix
> compilation on the venerable Unix.
> so r3620 and r3621 have completed r3603.
>
> @Michal and Greg: could you please counter check that everything is
> 100% fine on your side?
>

Looks good, thanks.

I'll post minor cosmetic patch later (whole reporting as separate 
function). Actually, it might be perhaps good at some point to move it 
to generic file with serial stuff - as it's pretty much driver agnostic.