[Nut-upsdev] Riello patch

Charles Lepple clepple at gmail.com
Wed Nov 21 22:31:52 UTC 2012


Thanks for submitting this patch.

In addition to Arnaud's suggestions, I should point out that our instance of Buildbot is picking up a few warnings:

../../drivers/riello_ser.c:162: warning: comparison is always true due to limited range of data type
../../drivers/riello_ser.c:165: warning: comparison is always true due to limited range of data type
../../drivers/riello_ser.c:385: warning: cast from pointer to integer of different size
../../drivers/riello_ser.c:456: warning: cast from pointer to integer of different size
../../drivers/riello_ser.c:500: warning: cast from pointer to integer of different size

This was from http://buildbot.networkupstools.org/public/nut/builders/MacOSX-10.6-x86/builds/280/steps/compile/logs/warnings%20(5)

I haven't looked at these in detail.

Overall status is here: http://buildbot.networkupstools.org/public/nut/waterfall

-- 
Charles Lepple
clepple at gmail






More information about the Nut-upsdev mailing list