[Nut-upsdev] [PATCH][RFC] OpenUPS driver

[Arnaud Quette]

2012/11/28 Nicu Pavel <npavel at mini-box.com>

> Hi,


Hi

thanks for your patches.
though I've started to process your 1rst patch 6 days ago, my current
latency should push me in acknowledging first...
note that I've discarded your 2nd patch, since the issue was already well
addressed.

A small update to the patch with correct names for upower-hid.rules and a
> running dump for openups.
>

I committed your 1rst patch, with some changes
(r3791<http://trac.networkupstools.org/projects/nut/changeset/3791>
):

- I've bumped usbhid-ups version to 0.38

- I've moved openups-hid.h include into the ifndef SHUT_MODE in usbhid-ups.h

- I've fixed "upower, udev & friends" issue the right way:
mfr name has to be a comment on the line preceding the #define MFR_VENDORID
0x????
You've probably trimmed it since it was "OpenUPS" (maybe a different case)
instead of Minibox.

- I've commented the "battery.cell<n>.voltage" variables.
As stated in docs/nut-names.txt (aka "NUT command and variable naming
scheme"):
"If you need a new variable or command name, contact the Development Team
first."
This will need a dedicated discussion, still on -upsdev

- I've moved "therm_tbl & size" from openups-hid.h to .c

- BTW, there are some non-compliance such as with Usage IDs for "Cell?"
(0x0000000?):
as per the HID/PDC
spec<http://www.usb.org/developers/devclass_docs/pdcv10.pdf>,
§ 4:
"Usage pages xFF00 to xFFFF are reserved by HID for vendor-specific
implementation."

- battery.capacity is in Ah!
and you'll have to actually fill in your (FW) string descriptor ;)

cheers,
Arnaud
-- 
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20121128/e8536b60/attachment.html>