[Nut-upsdev] [nut] usbhid-ups: trailing spaces in nut-scanner output not ignored when trying to find ups (#26)

Charles Lepple clepple at gmail.com
Tue Apr 30 12:11:03 UTC 2013


On Apr 29, 2013, at 9:21 AM, Christian Wiese wrote:

> I doubt that it is a "strange version of libusb". I am using libusb 1.0.9 which was build from vanilla sources without any additional patches.

Hmm. Just for completeness, which version of libusb-compat?

> What if libusb doesn't take care at all if there a trailing spaces when reading device information taking the gathered infos as they are?

That's what is confusing me. Spaces are apparently not treated specially anywhere in libusb-1.0, libusb-compat, or NUT. USB descriptors tend to have explicit lengths, too. I'm concerned this is masking some off-by-one error.

On the other hand, I don't want to be too pedantic about this. I'm fine with merging this for now, possibly with a note in the documentation in case someone in the future figures out what is really going on.

@aquette or @balooloo : are either of you working on nut-scanner?

Ref: https://github.com/networkupstools/nut/issues/26#issuecomment-17166035





More information about the Nut-upsdev mailing list