[Nut-upsdev] bcmxcp: Patch for using command map if present to control commands added by dstate_addcmd

Charles Lepple clepple at gmail.com
Wed Jul 3 20:15:49 UTC 2013

On Jul 3, 2013, at 3:06 PM, Alf Høgemark wrote:

> Inspired by the changes by Prachi Gandhi to use the command map from the UPS in the bcmxcp driver, I think the map should be used, if available, to control
> all commands the driver adds using "dstate_addcmd".
> The following patch is an attempt at doing so. The patch is against the bcmxcp branch.

Looks good overall, but I can't seem to get the patch to apply with 'git am'. It looks like your email client is adding a few spaces to the beginning of lines. Could you please re-send the last two patches as attachments?

Here's an example: http://article.gmane.org/gmane.comp.monitoring.nut.devel/6466/raw

Also, as for the content, we should probably push some of the bool_t stuff into a common header file, since it seems to be used in several places.


Charles Lepple
clepple at gmail

More information about the Nut-upsdev mailing list