[Nut-upsdev] Fwd: Forward of moderated message
clepple at gmail.com
Tue Aug 28 02:23:53 BST 2018
[forwarded without attachments, for real this time]
> Begin forwarded message:
> From: Gabriele TAORMINA <gabriele.taormina at legrand.com <mailto:gabriele.taormina at legrand.com>>
> Subject: Re: [Nut-upsdev] Adding drivers to NUT?
> Date: August 27, 2018 at 6:03:55 AM EDT
> To: Daniele Pezzini <hyouko at gmail.com <mailto:hyouko at gmail.com>>
> Cc: "nut-upsdev at alioth-lists.debian.net <mailto:nut-upsdev at alioth-lists.debian.net>" <nut-upsdev at alioth-lists.debian.net <mailto:nut-upsdev at alioth-lists.debian.net>>, Stefano PONGILUPPI <stefano.pongiluppi at legrand.com <mailto:stefano.pongiluppi at legrand.com>>, Thierry DESTRUEL <thierry.destruel at legrand.fr <mailto:thierry.destruel at legrand.fr>>
> Dear Daniele,
> sorry for the delay, I forgot to put the automatic response (I was on holiday), here's a description of what we made and the drivers we used to start from:
> - usbhid-ups --> we added legrand-hid subdriver to extend the support to our HID Devices (Keor SP and Keor PDU, following your dev guide)
> Added Source files: legrand-hid.c | legrand-hid.h
> - metasys --> this driver should be replaced (if possible) with the new one we made called "Legrand_megawhad". This driver was for MetaSystem UPSs, but this company has been acquired by Legrand, so we prefer to replace the old driver with the new one, even because we solved some issue and added new models (Compatibility: Megaline and Whad / Whad HE Series)
> Added Source files: legrand_megawhad.c
> - nutdrv_qx --> we added our VID:PID to Krauler subdriver (together with the patch you sent me last time)
> Added Source files: none
> if you need other files I'm here!
> I also attached the Megaline / Whad UPSs communication protocol as requested.
> Best Regards,
> Gabriele Taormina
> UPS Strategic Business Unit
> Field Application Engineer
> Phone: +39 0522/207046
> Fax: +39 0522/207005
> Address: Via Rodano 1 - Reggio Emilia - 42124 - Italy
> Email: gabriele.taormina at legrand.com <mailto:gabriele.taormina at legrand.com>
> <mailto:gabriele.taormina at legrand.com>Website: www.ups.legrand.com <http://www.ups.legrand.com/>
> Website: www.legrand.com <http://www.legrand.com/>
> Da: Daniele Pezzini <hyouko at gmail.com <mailto:hyouko at gmail.com>>
> Inviato: venerdì 3 agosto 2018 02:15
> A: Gabriele TAORMINA
> Cc: nut-upsdev at alioth-lists.debian.net <mailto:nut-upsdev at alioth-lists.debian.net>; Stefano PONGILUPPI; Thierry DESTRUEL
> Oggetto: Re: [Nut-upsdev] Adding drivers to NUT?
> > I have some news regarding the Driver: I applied the patch you sent me (https://github.com/zykh/nut/tree/issue-441 <https://github.com/zykh/nut/tree/issue-441>) and it works correctly (obviously in Level 5 of Debug I see "missing CR...etc..").
> Good to hear.
> > As for now there are 2 modification I'd like to suggest you:
> > - For Online Type UPSs the Megatec protocol describes that the battery voltage is provided in the form of V per Cell, not V per block, but the driver doesn't care because I see 2.21V instead of 36V in UPSC (Battery.voltage). I think that this should be corrected so the customer can see the string voltage and not the single Cell voltage (Megatec 0.06).
> Right, thanks for pointing out (if only all devices strictly adhered
> to the standard and reported it the right way...).
> While we tend to avoid touching the values we get from the device if
> not absolutely necessary, I think this can be done... it should not be
> overly difficult.
> Anyone on the list against it?
> > - About battery low and high guesstimation the formula uses these values:
> > batt.volt.low = 104 * batt.volt.nom / 120 (for a 12V VRLA --> 10.4V batt.volt.low)
> > batt.volt.high = 130 * batt.volt.nom / 120 (for a 12V VRLA --> 13V batt.volt.high).
> > In my opinion these values are not correct (a 12V lead acid battery can be charged up to 13.8V while discharged to 9.6V)
> > Instead I would suggest:
> > batt.volt.low = 100 * batt.volt.nom / 120 (for a 12V VRLA --> 10V batt.volt.low)
> > batt.volt.high = 135 * batt.volt.nom / 120 (for a 12V VRLA --> 13.5V batt.volt.high)
> > with this correction we have also some "Safe Margin", I mean that more or less all the UPS I tested will charge and discharge the batteries at those values.
> Seems reasonable to me.
> I'll have to look at our DDL and lists (I vaguely remember a lot of
> chit-chat about this kind of things in the heydays) for side effects,
> (Arno, where did you get those values from?)
> Hey list, thoughts on this?
> > I would like also to ask you if for this first time we can send you the sources instead of the Diff patch and for the future we will study how to send it in the format required (if you have any link explaining the diff, etc. please send it, it will be useful for me).
> Sure (compressed), just tell us from what you started so that we can
> generate a diff.
> As for the diff format, we use git as VCS, so `git format-patch` is a
> natural candidate: https://git-scm.com/docs/git-format-patch <https://git-scm.com/docs/git-format-patch>
> Actually, for small patches even `git diff` will do.
> Otherwise, run `diff -u` on the files you modified against the
> original ones: http://man7.org/linux/man-pages/man1/diff.1.html <http://man7.org/linux/man-pages/man1/diff.1.html>
> Also, we have some related chapters in our developer guide:
> https://networkupstools.org/docs/developer-guide.chunked/ar01s03.html <https://networkupstools.org/docs/developer-guide.chunked/ar01s03.html>
> Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir des informations sensibles et/ ou confidentielles ne devant pas être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous recevez ce message par erreur), nous vous remercions de le notifier immédiatement à son expéditeur, et de détruire ce message. Toute copie, divulgation, modification, utilisation ou diffusion, non autorisée, directe ou indirecte, de tout ou partie de ce message, est strictement interdite.
> This e-mail, and any document attached hereby, may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden.
-------------- next part --------------
An HTML attachment was scrubbed...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4655 bytes
Desc: not available
More information about the Nut-upsdev