[Nut-upsdev] Add support for Ablerex Dk+ #979
Johnson-shen
johnson-shen at ablerex.com.tw
Tue Apr 6 11:22:42 BST 2021
Dear Sir,
Could you merge our driver for us?
Because PID=0000/VID=FFFF of blazer_USB is Ablerex’s Identification
code. And this time the modification is only for the addition of Ablerex
product features, so there is no need to consider the differences of
other customers. Could you agree?
Regards!
Johnson
Jim Klimov 於 4/4/2021 7:43 PM 寫道:
> Hello,
>
> I am really sorry about the delay, I hoped our community expert on
> the Qx drivers would recommend the best course of action, but he did
> not reply yet.
>
> To me it currently seems that this Pull request:
> https://github.com/networkupstools/nut/pull/638/files
> <https://github.com/networkupstools/nut/pull/638/files> represents the
> modernly desirable addition of a USB protocol subdriver (in
> nutdrv_qx.c/.h) and the vendor protocol nuances subdriver (in separate
> files).
>
> Sadly, according to comment trail, that particular Pull request
> changed a bit of logic in existing functions (around langid_fix and
> enabling a hunnox patch, most prominently) and there were concerns if
> it is not breaking anything for other devices that work currently. It
> would be beneficial if people running nutdrv_qx today could build that
> branch and confirm into PR comments that the updated driver does work
> well or does break something after all.
>
> So I think the new ablerex subdriver should carefully take a similar
> path. Nutdrv_qx modular code did grow as a refactoring and merge of
> earlier drivers including blazer, so your original code contribution
> should be easily portable into the new layout.
>
> Thank you very much and really sorry it took longer that I'd expect,
> Jim Klimov
>
>
> On Mon, Mar 29, 2021, 13:16 Johnson-shen <johnson-shen at ablerex.com.tw
> <mailto:johnson-shen at ablerex.com.tw>> wrote:
>
> Dear Sir,
>
> Thank you for your reply.
>
> I can not sure what you mean.
>
> May I confirm with you again about it?
>
> You did not recommend that extend the new function from
> blazer_usb.c for Ablerex UPS.
>
> You suggest that separate the Ablerex function into a new
> driver(.c or .h) independently to avoid vendor nuances.
>
> Until we follow the above rule to modify, It will be upload and
> merge the driver.
>
> Is it right?
>
> Please kindly provide more information or explain to us, if I got
> you wrong.
>
> Please kindly provide the example for a new structure to us, I
> think will help to modify it for reference, if it is right.
>
> Regards!
> Johnson
>
>
>
>
> Jim Klimov 於 3/24/2021 6:26 PM 寫道:
>> Hello,
>>
>> Yes, in fact there were two things.
>>
>> One was that a week ago I posted some documentation updates into
>> your PR (e.g. for acknowledgements) and asked you to confirm they
>> sit well with you, and hoped that's it.
>>
>> Unfortunately, I was now reminded that extending the blazer_usb
>> driver was not a good approach - it was (poorly, fixing that)
>> documented as heading to obsoletion and eventual removal from
>> codebase. Various drivers for Qx protocols were aggregated in
>> drivers/nutdrv_qx*.{c,h} as a common core and clean separate
>> sources for vendor nuances.
>>
>> In order for us to maintain support for your device in the long
>> run, and not lose it when old redundant drivers do get dropped,
>> your code contribution should be relocated to this newer
>> structure, and importantly - re-tested with your hardware we do
>> not have access to. I hope Daniele (CC'ed) can clarify this
>> better if you would need assistance.
>>
>> Sorry about not noticing this earlier,
>> Jim Klimov
>>
>> On Wed, Mar 24, 2021, 03:58 Johnson-shen
>> <johnson-shen at ablerex.com.tw
>> <mailto:johnson-shen at ablerex.com.tw>> wrote:
>>
>> Dear Sir,
>>
>> The status of the project is waiting for the other managers
>> to verify and confirm?
>>
>> Please advise me if you have any support for this project.
>>
>>
>> Regards!
>>
>> Johnson
>>
>>
>>
>>
>>
>> Jim Klimov 於 3/18/2021 8:07 PM 寫道:
>>> Hello, thanks for the driver update and sorry that I had to
>>> be reminded of the PR by mailing list. I reviewed it last
>>> week and added a few points on documentation. Can you please
>>> check those, that I did not mistake something, and I think
>>> it is good to merge. Thanks again!
>>>
>>> Jim Klimov
>>>
>>> On Thu, Mar 18, 2021, 11:33 Johnson-shen
>>> <johnson-shen at ablerex.com.tw
>>> <mailto:johnson-shen at ablerex.com.tw>> wrote:
>>>
>>> Dear Wolfy,
>>>
>>> Please advise me, if you need more information about the
>>> new driver.
>>> Also please kindly update the status of the new driver
>>> for us.
>>>
>>> Regards!
>>> Johnson
>>>
>>>
>>>
>>> Johnson-shen 於 3/10/2021 6:24 PM 寫道:
>>>> Dear Wolfy,
>>>>
>>>> Please refer to the below table for the whole support
>>>> list of the UPS Model of the new driver.
>>>>
>>>>
>>>>
>>>> Please kindly advise me if you have any questions.
>>>>
>>>> Regards!
>>>> Johnson
>>>>
>>>>
>>>>
>>>>
>>>> Johnson-shen 於 3/10/2021 9:43 AM 寫道:
>>>>> Dear Wolfy,
>>>>>
>>>>> Thank you for the reply to emails quickly, the DK+ is
>>>>> our customer model name for ODM.
>>>>>
>>>>> We will provide the whole support list of UPS Model
>>>>> of the driver to you tomorrow.
>>>>>
>>>>>
>>>>>
>>>>> Regards!
>>>>>
>>>>> Johnson
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Manuel Wolfshant 於 3/9/2021 7:11 PM 寫道:
>>>>>> On 3/9/21 8:37 AM, John wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I'm engineer from Ablere Electronics Co., Ltd.
>>>>>>> (http://www.ablerex.com.tw/
>>>>>>> <http://www.ablerex.com.tw/>).
>>>>>>>
>>>>>>> I pull request to networkupstools/nut that Add
>>>>>>> support for Ablerex Dk+ #979.
>>>>>>>
>>>>>>
>>>>>> long time user of an MS3000RT here. where is the DK+
>>>>>> described? I cannot find it on your web site or via
>>>>>> google.
>>>>>>
>>>>>>
>>>>>> wolfy
>>>>>>
>>>>>
>>>>> --
>>>>> 盈正豫順電子股份有限公司
>>>>>
>>>>> Ablerex Electronics Co., Ltd.
>>>>>
>>>>> 研發部 / 沈南村
>>>>>
>>>>> E-mail:Johnson-shen at ablerex.com.tw <mailto:Johnson-shen at ablerex.com.tw>
>>>>>
>>>>> Tel: 886-7-397-8640 Ext: 894
>>>>>
>>>>> Fax: 886-7-3978641
>>>>>
>>>>> 807-66高雄市三民區水源路157號
>>>>>
>>>>> No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
>>>>> (R.O.C.)
>>>>
>>>>
>>>> --
>>>> 盈正豫順電子股份有限公司
>>>>
>>>> Ablerex Electronics Co., Ltd.
>>>>
>>>> 研發部 / 沈南村
>>>>
>>>> E-mail:Johnson-shen at ablerex.com.tw <mailto:Johnson-shen at ablerex.com.tw>
>>>>
>>>> Tel: 886-7-397-8640 Ext: 894
>>>>
>>>> Fax: 886-7-3978641
>>>>
>>>> 807-66高雄市三民區水源路157號
>>>>
>>>> No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
>>>> (R.O.C.)
>>>
>>>
>>> --
>>> 盈正豫順電子股份有限公司
>>>
>>> Ablerex Electronics Co., Ltd.
>>>
>>> 研發部 / 沈南村
>>>
>>> E-mail:Johnson-shen at ablerex.com.tw <mailto:Johnson-shen at ablerex.com.tw>
>>>
>>> Tel: 886-7-397-8640 Ext: 894
>>>
>>> Fax: 886-7-3978641
>>>
>>> 807-66高雄市三民區水源路157號
>>>
>>> No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
>>> (R.O.C.)
>>>
>>> _______________________________________________
>>> Nut-upsdev mailing list
>>> Nut-upsdev at alioth-lists.debian.net
>>> <mailto:Nut-upsdev at alioth-lists.debian.net>
>>> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev
>>> <https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev>
>>>
>>
>> --
>> 盈正豫順電子股份有限公司
>>
>> Ablerex Electronics Co., Ltd.
>>
>> 研發部 / 沈南村
>>
>> E-mail:Johnson-shen at ablerex.com.tw <mailto:Johnson-shen at ablerex.com.tw>
>>
>> Tel: 886-7-397-8640 Ext: 894
>>
>> Fax: 886-7-3978641
>>
>> 807-66高雄市三民區水源路157號
>>
>> No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
>> (R.O.C.)
>>
>
> --
> 盈正豫順電子股份有限公司
>
> Ablerex Electronics Co., Ltd.
>
> 研發部 / 沈南村
>
> E-mail:Johnson-shen at ablerex.com.tw <mailto:Johnson-shen at ablerex.com.tw>
>
> Tel: 886-7-397-8640 Ext: 894
>
> Fax: 886-7-3978641
>
> 807-66高雄市三民區水源路157號
>
> No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
> (R.O.C.)
>
--
盈正豫順電子股份有限公司
Ablerex Electronics Co., Ltd.
研發部 / 沈南村
E-mail: Johnson-shen at ablerex.com.tw
Tel: 886-7-397-8640 Ext: 894
Fax: 886-7-3978641
807-66高雄市三民區水源路157號
No.157, Shuiyuan Rd., Sanmin District, Kaohsiung City 807-66, Taiwan
(R.O.C.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20210406/2895d04a/attachment-0001.htm>
More information about the Nut-upsdev
mailing list