<span class="gmail_quote"></span><div><div>Hi Kirill,<br>
<br>
</div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Attached is my patch to add support for AL175 alarm module,<br>Please ACK or NAK this.
<br><br>
</blockquote></div><br>
there are some things that need to be reworked:<br>
<br>
* variables: <br>
(see <a href="http://eu1.networkupstools.org/doc/2.0.1/new-names.html">http://eu1.networkupstools.org/doc/2.0.1/new-names.html</a>)<br>
all the below vars are non standard. what do you put in all of these?<br>
thanks to detail back, as in new names.<br>
<br>
- load.fuse<br>
- battery.fuse<br>
- symalarm.fuse<br>
- battery.contactor<br>
- load.contactor<br>
- lvd.contactor<br>
<br>* load.current: this var doesn't exist! If it's the output current, then the right var is output.current.<a href="http://driver.name"></a><br>
* <a href="http://driver.name">driver.name</a> is already published by the core (main.c), so you can remove it.<br clear="all">* you should use the internal xmalloc() function<br>
* please send your diff in unified format (diff -Nru orig.tree modified.tree)<br>
* the driver's manpage is missing (al175.8)<br>
<br>More generally, please read the following to ensure you comply with NUT standard for coding, variables names, ... :<br>
<a href="http://eu1.networkupstools.org/doc/2.0.1/developers.html">http://eu1.networkupstools.org/doc/2.0.1/developers.html</a><br>
<a href="http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html">http://eu1.networkupstools.org/doc/2.0.1/new-drivers.html</a><br>
<a href="http://eu1.networkupstools.org/doc/2.0.1/new-names.html">http://eu1.networkupstools.org/doc/2.0.1/new-names.html</a><br>
<br>
Please, correct the above, and discuss on upsdev the variables problem...<br>
<br>
Thanks for your contribution,<br>Arnaud <br>-- <br>Linux / Unix Expert - MGE UPS SYSTEMS - R&D Dpt<br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/">http://www.networkupstools.org/
</a><br>Debian Developer -
<a href="http://people.debian.org/%7Eaquette/">http://people.debian.org/~aquette/</a><br>OpenSource Developer - <a href="http://arnaud.quette.free.fr/">http://arnaud.quette.free.fr/</a>