<html>
<body>
<font size=3>Peter,<br>
Yep, at the moment the Krauler driver works OK for me. So if
you want to make the change that is fine.<br><br>
Regards<br>
Jon<br><br>
At 03:42 9/02/2007, Peter Selinger wrote:<br>
<blockquote type=cite class=cite cite="">Hi Alexander,<br><br>
thanks for your good work on the megatec_usb driver. I have made a
few<br>
more (cosmetic) changes.<br><br>
Is the driver now working stably for your device? In particular, do<br>
the instant commands (and particularly "upsdrvctl -k"
<img src="http://messenger.msn.com/MMM2004-08-11_11.52/Resource/emoticons/wink_smile.gif" width=19 height=19 alt="Winking smiley"> work
properly? <br>
In this case, we could hopefully mark the device as "supported"
and<br>
merge the driver to the main branch. <br><br>
There is still the question of whether to keep separate code for<br>
Ablerex and Krauler. From what I understand, each of these
subdrivers<br>
works for each of the devices. But the Krauler driver is now more<br>
advanced (with the retry feature), so we could remove the Ablerex<br>
subdriver (provided Jon tests the Krauler one to make sure it still<br>
works for the Ablerex device).<br><br>
If I understand correctly, the only change needed would be to
change<br><br>
{0xffff, 0x0000, get_data_ablerex,
set_data_ablerex},<br><br>
to <br><br>
{0xffff, 0x0000, get_data_krauler,
set_data_krauler},<br><br>
is that correct? -- Peter<br><br>
Alexander Gordeev wrote:<br>
> <br>
> Author: agordeev-guest<br>
> Date: Thu Feb 8 16:43:43 2007<br>
> New Revision: 801<br>
> <br>
> Modified:<br>
> branches/megatec-usb/ChangeLog<br>
> branches/megatec-usb/drivers/megatec_usb.c<br>
> Log:<br>
> - drivers/megatec_usb.c: fixed the problem with report descriptor
retrieval at driver startups which caused failures. Since none of the
subdrivers needs this descriptor it isn't retrieved at all.<br>
> <br>
> <br>
> Modified: branches/megatec-usb/ChangeLog<br>
>
==============================================================================<br>
> ---
branches/megatec-usb/ChangeLog<x-tab> </x-tab>
(original)<br>
> +++
branches/megatec-usb/ChangeLog<x-tab> </x-tab>Thu
Feb 8 16:43:43 2007<br>
> @@ -1,3 +1,9 @@<br>
> +Thu Feb 8 15:43:00 UTC 2007 / Alexander I. Gordeev
<lasaine@lvk.cs.msu.su><br>
> +<br>
> + - drivers/megatec_usb.c: fixed the problem with report
descriptor<br>
> + retrieval at driver startups which caused failures.
Since none of the<br>
> + subdrivers needs this descriptor it isn't retrieved at
all.<br>
> +<br>
> Thu Feb 8 15:26:37 UTC 2007 / Alexander I. Gordeev
<lasaine@lvk.cs.msu.su><br>
> <br>
> - drivers/megatec_usb.c: fixed "UPS No Ack"
issue and optimized<br>
> <br>
> Modified: branches/megatec-usb/drivers/megatec_usb.c<br>
>
==============================================================================<br>
> ---
branches/megatec-usb/drivers/megatec_usb.c<x-tab>
</x-tab>(original)<br>
> +++
branches/megatec-usb/drivers/megatec_usb.c<x-tab>
</x-tab>Thu Feb 8
16:43:43 2007<br>
> @@ -152,7 +152,7 @@<br>
> }<br>
> }<br>
> <br>
> - ret =
usb->open(&udev,&hiddevice,&match,u.report_desc,MODE_OPEN);<br>
> + ret =
usb->open(&udev,&hiddevice,&match,u.report_desc,MODE_REOPEN);<br>
> if (ret<0)<br>
>
usb_open_error(port);<br>
> <br>
> <br>
> _______________________________________________<br>
> nut-commits mailing list<br>
> nut-commits@lists.alioth.debian.org<br>
>
<a href="http://lists.alioth.debian.org/mailman/listinfo/nut-commits" eudora="autourl">
http://lists.alioth.debian.org/mailman/listinfo/nut-commits</a><br>
> </font></blockquote>
<BR><BR>
<TABLE width=400><HR>
<P style="FONT: 9pt/11pt verdana"><a href="http://www.avast.com">avast! Antivirus</a>: Outbound message clean.
<P style="FONT: 8pt/11pt verdana">Virus Database (VPS): 000712-1, 08/02/2007<BR>Tested on: 9/02/2007 5:04:21 AM<BR><FONT color=gray>avast! is copyright (c) 2000-2007 ALWIL Software.</FONT></P>
<TBODY></TBODY></TABLE>
<BR>
</body>
<br>
</html>