<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Mar 26, 2010, at 8:32 PM, Arnaud Quette wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">2010/3/22 Charles Lepple <span dir="ltr"><<a href="mailto:clepple@gmail.com">clepple@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; "> On Mar 19, 2010, at 1:21 PM, Arnaud Quette wrote:<br> <blockquote class="gmail_quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; "> <br> <blockquote class="gmail_quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; "> [...]<div class="im"><br> At r2403, the code does not force the creation of a ChangeLog if a<br> user simply checks out the source, then runs autoreconf, configure and<br> make. I am wondering if we should remove the "|| echo" portion, and<br> simply add a "touch ChangeLog" on the buildslaves that don't have<br> svn2cl (and wouldn't need it, since they are not all distributing<br> tarball snapshots).<br> </div></blockquote><div class="im"> <br> nice job.<br> I'm in favor of keeping the failure warning msg, while touching ChangeLog.<br> note that I haven't yet had a chance to test it though.<br> </div></blockquote> <br> Hmm, maybe I misinterpreted "keeping the failure warning message".<br></blockquote><div> <br>I was not quite clear indeed!<br>echo "svn2cl failed to generate the ChangeLog. See <a href="http://trac.networkupstools.org/projects/nut/timeline" target="_blank">http://trac.networkupstools.org/projects/nut/timeline</a>" > ChangeLog<br></div></div></blockquote><div class="gmail_quote"><div> <br></div><div>OK, I just committed that again.</div><div><br></div></div><blockquote type="cite"><div class="gmail_quote"></div>putting the above msg into ChangeLog is fine. also echo'ing it would be a plus.<br></blockquote><div><br></div><div>The message should be visible from the 'make' output.</div><br><blockquote type="cite">the cherry for maintainability would be an "UP_TO_VERSION" param that get the revision number, using something like:<br> svn log -v -q --stop-on-copy svn://<a href="http://svn.debian.org/nut/tags/v2.4.3">svn.debian.org/nut/tags/v2.4.3</a><br></blockquote></div><br><div>We can run that manually, if we really need to adjust the start point of the ChangeLog. Alioth's SVN service is not particularly fast, so if the UP_TO_VERSION hasn't changed, I don't think we want to be polling for it every time we build.</div><div><br></div><div>If this builds properly, I will merge it into the trunk.</div><div><br></div><div>-- </div><div>Charles Lepple</div><div>clepple@gmail</div></body></html>