<div class="gmail_quote">2011/5/14 Keven L. Ates <span dir="ltr"><<a href="mailto:atescomp@gmail.com" target="_blank">atescomp@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Arnaud,<br></blockquote><div><br>Hi Keven,<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div>
On May 13, 2011 8:21am, Arnaud Quette <<a href="mailto:aquette.dev@gmail.com" target="_blank">aquette.dev@gmail.com</a>> wrote:<br>
> I've just merged your patch (r2984), with just one change: the driver revision was already 0.12, since I've bumped to 0.13, along with your comment.<br>
> As a side note, could you please check to improve upsdrv_help() and upsdrv_makevartable() output.<br>
><br>
> These should fit on a 80 column terminal, to ensure it is useful in all possible cases.<br>
><br>
> This so needs some more formating, probably simplification and reference to the manual page.<br>
<br>
</div>I reformatted these two support function as requested. I also fixed<br>
up the powercom man page, but can't attest to its "man page"<br>
correctness. The attached patch file has the fixes.<font color="#888888"><br>
</font></blockquote></div><br>waow, awesome!<br>I'd like all contributions to be as complete and perfect as yours. <br><br>I've just committed it (r2990), with 2 minors fixes:<br>- added a comma before your name, in powercom.txt<br>
- added a comment reference to upsdebug_hex(), l.371 in powercom.c. You may want to look at it ;-)<br><br>a last question: would you be interested in becoming the official maintainer for this driver?<br><br>thanks a lot.<br clear="all">
Arnaud<br>-- <br>Linux / Unix Expert R&D - Eaton - <a href="http://powerquality.eaton.com" target="_blank">http://powerquality.eaton.com</a><br>Network UPS Tools (NUT) Project Leader - <a href="http://www.networkupstools.org/" target="_blank">http://www.networkupstools.org/</a><br>
Debian Developer - <a href="http://www.debian.org" target="_blank">http://www.debian.org</a><br>Free Software Developer - <a href="http://arnaud.quette.free.fr/" target="_blank">http://arnaud.quette.free.fr/</a><br><br>