[PATCHv2] Re: Convert to use OptionParser for command line handling.

Nicolas Sebrecht nicolas.s-dev at laposte.net
Tue Dec 14 21:49:14 UTC 2010


On Mon, Dec 13, 2010 at 06:15:06PM -0600, Sebastian wrote:
> 
> From: Sebastian Spaeth <Sebastian at SSpaeth.de>
> 
> THe main purpose of this patch is to move the command line option
> handling from the more manual "getopts" module to the full fledged
> "OptionParser".

Would change to:

  Move the command line option handling from the more manual "getopts"
  module to the full fledged "OptionParser".

>                 It has the advantage of e.g. automatically creating
> the Help text that is shown with the "-h/--help" option rather than
> having to hardcode the text and format the line breaking manually.
> (admittedly in a beautifully justified manner :-)).
> 
> Also, do away with the versino check when invoking OfflineImap so we

...and "versino" to "version".

> do not have to change the version number in three places when bumping
> it.
> 
> Signed-Off-By: Sebastian Spaeth <Sebastian at SSpaeth.de>
> ---
> This patch addresses all comments in Nicolas' review.
> Thanks for spotting all that!!!
> I suggest that further wording improvments go into separate patches though.

Yes. But the current patch does not apply.

-- 
Nicolas Sebrecht



More information about the OfflineIMAP-project mailing list