[PATCHv3] Re: Don't always sleep while waiting for exited threads

Nicolas Sebrecht nicolas.s-dev at laposte.net
Sun Dec 5 18:20:21 GMT 2010

On Sat, Dec 04, 2010 at 08:22:07PM -0500, Leif Walsh wrote:

>    You should probably do the code changes and doc changes in separate
>    commits so they can be reverted separately. Generally, changes that do not
>    depend on each other to work correctly should be separated for this
>    reason. You should note the change to the code in the docs (in the same
>    commit) then do the change to sphinx style in another commit.

You're right and wrong at the same time.

Yes, unrelated changes must be seperated commits. But you'll see that
the comment change IS related to the code improvement. So they both have
to stand in the same commit. Reverting the code changeset _must_ revert
the comment changeset at the same time.

The style break would have to be reverted by writing a new commit with
content that does NOT exist today (neither in the patch nor in the current

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list