[PATCH 2/2] Don't fail mysteriously if we cannot get a password

Sebastian Spaeth Sebastian at SSpaeth.de
Mon Dec 13 16:44:17 GMT 2010


On Mon, 13 Dec 2010 09:33:18 -0600, Sebastian <Sebastian at SSpaeth.de> wrote:
> Rework repository.IMAP.getpassword() to not return None on failure which
> leads to mysterious Exceptions in the bowels of imaplib. Rather fail with a
> clear exception explaining what went wrong.
> 
> Some extended documentation and cleanups in the functino en-passent.

Oops. please don't apply this one yet. Raising an Exception rather than
returning None might have implications on how and whether we prompt the
user for a password. I had taken that into consideration, and I am not
very familiar with that part of the code.

So we need to look into why the UI doesn't ask for a password,  but
simply uses "None". One thing that comes to my mind is that not all UIs
support getting passwords from the user. 

Paul, try specifying -u Curses.Blinkenlights to see whether you are using a
different UI by default now.

Sebastian




More information about the OfflineIMAP-project mailing list