[PATCH 2/2] Re: Convert to use OptionParser for command line handling.

Nicolas Sebrecht nicolas.s-dev at laposte.net
Tue Dec 14 18:47:17 GMT 2010

On Mon, Dec 13, 2010 at 05:48:54PM -0600, Sebastian Spaeth wrote:
> On Mon, 13 Dec 2010 22:02:21 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:

> > You should use the imperative form "Use this with -1 in order to...".
> > But I'm more wondering if this option could just imply -1 without asking
> > the user to do so.
> I think this is the verbatim text from the original help text, so I
> don't take the blame for it :-). But I will try to reword it. As for -1,
> given that there is a thread debugging option, there are at least some
> cases where we might want to leave threading on while debugging.
> > We must be a bit more explicit on what would happen exactly. What
> > happens if the mail is already stored _but_ with another flag? Does it
> > download the mail in the new form or ignore it? Or something else?
> Not sure, this is the original text. If we had unit tests for these
> functions we would know. (sorry could not resist :-)). I believe it will
> ignore the mail then, but as I said, I am not sure about it.

I knew it probably didn't came from you. But since we are touching this
area, some help updates are welcome.

> > Oh, and please don't cull the cc list, even while sending patches!
> I did? Oh, I send the patches via "git send-email", so I would have to
> copy'n paste the cc list somehow out of the mails. WIll try to do that
> from now on.

I use the -cc= option of 'git send-email'. You're a developper and an
OfflineIMAP user, so I'm sure you'll fastly make your own wrapper around
git to automagically fill in the cc list to your patches. Perhaps basing
your script on the Message-ID of the mail your answering to? ,-)

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list