[PATCH] Re: Implement SSL certificate checking

Johannes Stezenbach js at sig21.net
Tue Dec 14 20:56:09 GMT 2010

On Tue, Dec 14, 2010 at 01:37:39PM -0600, Sebastian Spaeth wrote:
> On Tue, 14 Dec 2010 19:35:00 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > This commit message is poor. Explain here _why_ this patch.
> Righto. Will improve the commit message. This patch would probably need
> splitting into 2-3 separate patches anyway, and I just wanted to get it
> out for review quickly. That's why I didn't spent too much time
> composing it (also it was 5am or so :-)).

You're quick, that's good.  But it's also bad...
If you mix cleanups and functional changes, the patch is much harder
to review.  Please take the time to seperate the changes before asking
others to spend time reviewing it.

> Before this goes in, I would love to have it tested by a few persons
> (first on some unimportant accounts :-)) to see that it works in various
> situations.

"Works for me" is inadequate.  Seemingly working, but subtly broken
crypto is much worse than no crypto.  People need to be able to
rely on it to protect their mail.

I hope that doesn't sound too negative, I just think
it's important to get that right.


More information about the OfflineIMAP-project mailing list