[PATCH 00/13] Re: imaplib2/IDLE again

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Apr 25 10:31:00 UTC 2011


On Tue, Mar 08, 2011 at 10:05:13AM -0500, Ethan Glasser-Camp wrote:
> 
> Hi guys,
> 
> Please find attached the newest version of my imaplib2/IDLE patch series. Sorry about the month of delay; free time comes in bursts, it seems.
> 
> Improvements made:
> 
> - remove other unnecessary imports in patch 1
> - add Signed-off-by to every commit, including the one by Tom Lawton
> - delete read, readline, _read_upto. I left it for IMAP_Tunnel because I couldn't test it, and because it seemed like it might actually do something useful.
> - add note in imaplib->imaplib2 commit that we're gonna break the build
> - explain our choice to move to imaplib2 in a commit mesg
> - fix @jonah-hex.none author
> - revise patch 4 to make sure it handles the case with no EXISTS. I couldn't test this, this is based on reading the code.
> 
> Otherwise, it remains essentially the same as the last patch series. I'd again like to propose this for merging at some time in the near future. :)

Since v6.3.3 is out I tried to apply the "idle" part (patches 5-10, 13). It
rebase cleany but a simple 'make clean' gives me

  python setup.py clean --all
  Traceback (most recent call last):
    File "setup.py", line 27, in <module>
      import offlineimap
    File "/home/nicolas/dev/my/offlineimap/offlineimap/__init__.py", line 23, in <module>
      from offlineimap.init import OfflineImap
    File "/home/nicolas/dev/my/offlineimap/offlineimap/init.py", line 28, in <module>
      from offlineimap import accounts, threadutil, syncmaster
    File "/home/nicolas/dev/my/offlineimap/offlineimap/accounts.py", line 19, in <module>
      from offlineimap.repository import Repository
    File "/home/nicolas/dev/my/offlineimap/offlineimap/repository/__init__.py", line 18, in <module>
      from offlineimap.repository.IMAP import IMAPRepository, MappedIMAPRepository
    File "/home/nicolas/dev/my/offlineimap/offlineimap/repository/IMAP.py", line 20, in <module>
      from offlineimap import folder, imaputil, imapserver
    File "/home/nicolas/dev/my/offlineimap/offlineimap/imapserver.py", line 22, in <module>
      from offlineimap.accounts import syncfolder
  ImportError: cannot import name syncfolder
  make: [clean] Erreur 1 (ignorée)

Could you please send an updated topic?

-- 
Nicolas Sebrecht



More information about the OfflineIMAP-project mailing list