[PATCH 1/9] Re: We had been setting this variable twice

Sebastian Spaeth Sebastian at SSpaeth.de
Wed Apr 27 07:57:39 UTC 2011


On Tue, 26 Apr 2011 18:44:11 +0200, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > +            #TODO: what to do in case uid==0?
> >  
> >          if uid in self.messagelist:     # already have it
> >              self.savemessageflags(uid, flags)
> 
> Why this changeset? What has uid==0 so special?

Oh, that was more of a question to myself when going through the
code. Backends are supposed to return uid==0 if the saving of a message
was successful but the backend failed to return the new UID of the saved
message. In this case, the LocalStatus cache can not store the UID of
the newly saved message, and I am not sure what we *should* be doing in
this case.

The comment doesn't have to be part of the changeset, but it is a
question that needs some pondering.

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/offlineimap-project/attachments/20110427/ffe62643/attachment.pgp>


More information about the OfflineIMAP-project mailing list