[PATCH 2/2] Re: folder/IMAP: Remove buggy duplicate assignment

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Apr 11 17:55:03 BST 2011

On Mon, Apr 11, 2011 at 06:09:08PM +0200, Sebastian Spaeth wrote:
> Right after performing
>    for msgid in imapdata:
>       maxmsgid = max(long(msgid), maxmsgid)
> we were doing:
>    maxmsgid = long(imapdata[0])
> which is clearly bogus and a line that has been forgotten to be removed
> when we introduced the above iteration. This bug would fix a regression with
> those broken ZIMBRA servers that send multiple EXISTS replies.

This topic is unrelated with 1/2 and should have been sent seperatly.

While as is, I'm not totally satisfied with this message commit which
almost duplicates the patch itself without explaining _how_ it's
/clearly bogus/.

Anyway, I'm inclined to merge it as-is if you're too lazy for a rewrite.

> Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> ---
> This is clearly a bugfix that should go in before the next release.
> The real change is to remove the superfluous:
>                 maxmsgid = long(imapdata[0])
> The other line is just moving an assignment a few lines down.

Yes, I see. :)


Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list