[PATCH] Re: attempt to fix the IMAP4_Tunnel breakages

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Apr 11 18:07:05 BST 2011

On Mon, Apr 11, 2011 at 12:22:44PM -0400, Ethan wrote:
>    On Mon, Apr 11, 2011 at 12:10 PM, Nicolas Sebrecht
>    <[1]nicolas.s-dev at laposte.net> wrote:
>      Ok. Is it the reason why you didn't set your sign-off?
>      BTW, I wonder if we should merge this topic even without feedback.
>    Right, because they're still untested.  Just sent another one.  How do you
>    want to handle these patches?  We're up to three very small ones, or I
>    could collapse them into one big "fix IMAP4_Tunnel" commit.  I was
>    assuming you'd want to wait until things actually worked before merging,
>    since these intermediate "messy" commits may be better combined or
>    simplified.

It's up to you. I'll be fine with a squashed commit.

For the sign-off, I was talking for the case we don't get the feedback
you asked for. Now that I'm sure you don't intend this topic to be
merged as is, let's manage the feedback by yourself in order to make a
proper resent.

Thank you.

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list