[PATCH] Re: IMAP: improve quickchanged() performance
Sebastian at SSpaeth.de
Tue Apr 12 18:32:11 BST 2011
On Tue, 12 Apr 2011 19:17:06 +0200, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > > Can't we try to fetch a deleted UID, then? How do we handle such case?
> Not sure. Are we talking about _remote_ changes while syncing?
Yes, the quickchanged() checks if it should perform a regular sync or
not and it looks at changes on REMOTE. A change on REMOTE occured if it
a) has a different number of messages than we have recorded in the
b) the highest UID on REMOTE is not the highest UID in the status
It is case b) that I am not sure about if it brings a lot of
benefits. It catches some cases of changes on REMOTE that are not caught
otherwise, but it also means one more IMAP roundtrip per folder.
Not sure at all. We can probably leave it as it is now and think about
it when we picked all other low hanging fruit :-).
> > > What's going on the next sync? Do we detect both changes and propagate
> > > them locally?
> > Yes, we detect it properly on the next full sync, just not in the quick
> > case.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the OfflineIMAP-project