[PATCH] Re: IMAP: improve quickchanged() performance

[Nicolas Sebrecht]

On Fri, Apr 15, 2011 at 09:18:19AM +0200, Sebastian Spaeth wrote:
> On Thu, 14 Apr 2011 19:46:58 +0200, Nicolas Sebrecht wrote:

> Ahh, _now_ I get your issue, sorry I was a bit thick. You are asking what
> happens when changes occur on REMOTE while we are syncing.
> 
> That is a valid question, and one that we need to investigate
> deeper. But it is one that is not at all related to the quick setting or
> the quickchanged() function. :-)
> 
> 
> It is not a 'quick' issue, because we query the IMAP folder for the
> number of mails it has (and the highest UID) and if that is different
> From our LocalFolder status, we will just perform a plain old regular
> folder sync (which will fetch all IMAP mails and UIDs).
> 
> So, this is not an issue with 'quick' syncs. But it is an issue that we
> need to investigate for the regular folder sync case. I believe that
> when we e.g. try to copy a message that has been deleted since we
> fetched the status, we will raise an exception, and the mesage copying
> will be aborted. (However, I am not sure, *how* far the Exeption would
> bubble, e.g. if it would abort the whole folder sync.)

I get it, thanks. I agree merge your patch and will do unless someone
raise something else.

-- 
Nicolas Sebrecht