[PATCH 1/9] Re: We had been setting this variable twice
Nicolas Sebrecht
nicolas.s-dev at laposte.net
Tue Apr 26 17:44:11 BST 2011
On Tue, Apr 26, 2011 at 12:31:32PM +0200, Sebastian Spaeth wrote:
>
> This was in the code for a very long time, it seems.
> Remove one instance, no functional changes.
>
> Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> ---
> offlineimap/folder/LocalStatus.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/offlineimap/folder/LocalStatus.py b/offlineimap/folder/LocalStatus.py
> index 623829a..2bf46b8 100644
> --- a/offlineimap/folder/LocalStatus.py
> +++ b/offlineimap/folder/LocalStatus.py
> @@ -29,7 +29,6 @@ class LocalStatusFolder(BaseFolder):
> self.sep = '.'
> self.config = config
> self.dofsync = config.getdefaultboolean("general", "fsync", True)
> - self.filename = os.path.join(root, name)
> self.filename = repository.getfolderfilename(name)
> self.messagelist = None
> self.repository = repository
Ok.
> @@ -119,6 +118,7 @@ class LocalStatusFolder(BaseFolder):
> if uid < 0:
> # We cannot assign a uid.
> return uid
> + #TODO: what to do in case uid==0?
>
> if uid in self.messagelist: # already have it
> self.savemessageflags(uid, flags)
Why this changeset? What has uid==0 so special?
--
Nicolas Sebrecht
More information about the OfflineIMAP-project
mailing list