[PATCH 1/9] Re: We had been setting this variable twice

Nicolas Sebrecht nicolas.s-dev at laposte.net
Wed Apr 27 17:24:03 BST 2011

On Wed, Apr 27, 2011 at 09:57:39AM +0200, Sebastian Spaeth wrote:
> On Tue, 26 Apr 2011 18:44:11 +0200, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:

> > > +            #TODO: what to do in case uid==0?
> > >  
> > >          if uid in self.messagelist:     # already have it
> > >              self.savemessageflags(uid, flags)
> > 
> > Why this changeset? What has uid==0 so special?
> Oh, that was more of a question to myself when going through the
> code. Backends are supposed to return uid==0 if the saving of a message
> was successful but the backend failed to return the new UID of the saved
> message. In this case, the LocalStatus cache can not store the UID of
> the newly saved message, and I am not sure what we *should* be doing in
> this case.

Ok. Well, we should store 0 as it's the flag for such case. We can't
generate one in our side, so it makes sense to store 0. The next
question is how it can impact later sync process.

> The comment doesn't have to be part of the changeset, but it is a
> question that needs some pondering.

Thanks. Will remove this changeset. The comment should go somewhere in
the sync code (maybe in multiple places, don't know).

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list