[PATCH] Make flags a set rather than a list

Vincent Beffara vbeffara at ens-lyon.fr
Tue Aug 16 10:58:14 UTC 2011


Hi Sebastian,

Just one quick question. There are these two methods,

SS> def flagsimap2maildir(flagstring):
SS> def flagsmaildir2imap(maildirflaglist):

mapping from a list to a string representation, using a flagmap. To get
compatibility with Gnus, there is a hack somewhere on the web replacing
these two functions with essentially identical copies using a different
flag map. Your patch will break that hack.

But that's ok. I'm not complaining about that, I can adapt it ...

As you are going down that road, I seem to remember (no time to check
right now) that the flags are stored in the status file as exactly that
string. Any plan to store the set() of flags instead (it should be
picklable) ? Then these two functions would never be used in the
IMAP<->IMAP case, which feels a bit simpler.

If not (or in parallel), would it be easy to make the flagmap
configurable (to add something like ('gnus-expirable', 'E') to it) ? Or
would it make sense to even add 'E' in the source by default, it
shouldn't hurt anyone ?

Cheers,

        /vincent

-- 
|                 |   UMPA - ENS Lyon   | Mél: vbeffara at ens-lyon.fr |
| Vincent Beffara |  46 allée d'Italie  | Tél: (+33) 4 72 72 85 25  |
|                 | 69364 Lyon Cedex 07 | Fax: (+33) 4 72 72 84 80  |




More information about the OfflineIMAP-project mailing list