[PATCH 0/13] Reintegrate imaplib2 and IDLE, again
Sebastian at sspaeth.de
Mon Feb 7 16:29:38 GMT 2011
On Mon, 7 Feb 2011 11:11:33 -0500, Ethan <ethan.glasser.camp at gmail.com> wrote:
> imaplib2 doesn't define or use any method called readline(), as far as
> I can tell. See for yourself:
Which is good. More code to delete :)
> http://sydney.edu.au/engineering/it/~piers/python/imaplib2 | grep
Well, not only imaplib2 must not use readline() but offlineimap itself
must also not use it, and... it seems it doesn't. At least that is what
git grep over all of offlineimap suggests. So let's ditch those custom
functions and be done with them.
> Since imaplib2 doesn't define or use readline or _read_upto, and we
> don't call it directly ourselves, we should be able to delete them all
> without a problem. When I sent the patch, I hadn't yet grepped the
> codebase for use of these methods, so wasn't sure if they were being
> used somewhere.
Yep, let's remove those as well, so nobody is tempted to start using
them and break the code.
Would you update the patch to delete all those 3 custom methods? You need
to update them with your Signed-off-by: to make Nicolas happy anyway :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the OfflineIMAP-project