Patch for multi-response imap SELECT

Sebastian Spaeth Sebastian at SSpaeth.de
Fri Jan 7 09:23:30 UTC 2011


On Wed, 5 Jan 2011 19:53:28 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> I see we have now three patches for the same issue around Zimbra (the
> latter beeing sent some days ago by marvinthepa). The best patch seems
> to be the one from Lars Thalmann and Knut Anders Hatlen. I've reattached
> it further in this mail.
> 
> In order to merge the patch, I'd like:
> 
>   - confirmation I'm right about the best fix to apply
>   - a resent of the patch with the approppriate signed-off-by

A good analysis and IMHO this patch does the right thing to work around
the broken ZIMBRA server. What I would like to add here though is a
comment on why we act here as we act, so that nobody "optimizes" this
away in the future, not knowing why the code is why it is.

I added that comment to the
patch and attach the updated diff, with these changes, the patch has my:

Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-diff
Size: 1948 bytes
Desc: updated patch
URL: <http://lists.alioth.debian.org/pipermail/offlineimap-project/attachments/20110107/b0e1dfc1/attachment.diff>


More information about the OfflineIMAP-project mailing list