tarballs (was: [ANNOUNCE] OfflineIMAP v6.3.1 released)

[Thomas Kahle]

Hi,

sorry for not coming back to this earlier.

On 16:15 Thu 30 Dec     , Sebastian Spaeth wrote:
> > diff -U 3 -dHrN nicolas33-offlineimap-98f5181/offlineimap.py nicolas33-offlineimap-98f5181.new/offlineimap.py
> > --- nicolas33-offlineimap-98f5181/offlineimap.py	2010-12-09 19:52:48.000000000 +0100
> > +++ nicolas33-offlineimap-98f5181.new/offlineimap.py	2010-12-23 21:08:32.000000000 +0100
> > @@ -17,6 +17,7 @@
> >  #    along with this program; if not, write to the Free Software
> >  #    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> >  
> > +from locale import *
> >  from offlineimap import OfflineImap
> >  
> >  offlineimap = OfflineImap()
> 
> 
> Sorry, I did read that post and the linked bugs, but I still don't get
> the need for this patch (nor do I like importing "*" of a module without
> at least a hint what it is used for).
> 
> Grepping for "import locale" doesn't find anything in the offlineimap
> source. What exactly "import locale" in our code? Something hidden in
> the thread lib?
> 
> And why would we import stuff on my Linux box to fix some apparently
> broken Mac setup? We should make that propably conditional?
> I don't feel strongly about this point, but I'd like to know *why* we
> need that patch and why it fixes things.

First off: I have 'inherited' the patch from other Gentoo maintainers
before me.  Second, I don't have MacOS to do any experiments with this,
but from reading the post I think I understand that on MacOS there is a
'CoreFramework' that needs to be loaded before the threads using it are
started.  If I understand this correctly this is independent of the fact
that offlineimap uses python and can be reproduced in C.

I agree that importing everything from locale is a hack, only used to
make MacOS load the CoreFramework before threading.  Somebody who knows
more about the internals of MacOS could provide a patch how to properly
ensure that this thing is loaded before offlineimap starts to fork
threads.

Cheers,
Thomas


-- 
Thomas Kahle
http://dev.gentoo.org/~tomka/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 316 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/offlineimap-project/attachments/20110109/eda4de7f/attachment.pgp>