Patch for multi-response imap SELECT

Nicolas Sebrecht nicolas.s-dev at laposte.net
Fri Jan 7 18:23:35 GMT 2011


On Fri, Jan 07, 2011 at 10:23:30AM +0100, Sebastian Spaeth wrote:
> On Wed, 5 Jan 2011 19:53:28 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > I see we have now three patches for the same issue around Zimbra (the
> > latter beeing sent some days ago by marvinthepa). The best patch seems
> > to be the one from Lars Thalmann and Knut Anders Hatlen. I've reattached
> > it further in this mail.
> > 
> > In order to merge the patch, I'd like:
> > 
> >   - confirmation I'm right about the best fix to apply
> >   - a resent of the patch with the approppriate signed-off-by
> 
> A good analysis and IMHO this patch does the right thing to work around
> the broken ZIMBRA server. What I would like to add here though is a
> comment on why we act here as we act, so that nobody "optimizes" this
> away in the future, not knowing why the code is why it is.
> 
> I added that comment to the
> patch and attach the updated diff

Please, don't attach patches.

>                                    with these changes, the patch has my:
> 
> Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

Thanks. Could the original authors send their signed-off-by too?

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list