X-OfflineIMAP header was [Re: [PATCH] Avoid Fatal error...]

[Sebastian Spaeth]

On Fri, 21 Jan 2011 07:39:16 -0500, Philippe LeCavalier <support at plecavalier.com> wrote:
> Don't mean to butt in. Just an attempt to keep the list sane.

Thanks for that :)

Here comes another patch series based on master which is certainly
post-release material. It properly supports the UIDPLUS extension of a
mail server. ie when we are on an IMAP server that supports that, we
don't add any weird headers. At the same time, I added plenty of code
documentation and did some refactoring.

It consists of these 4 patches

0001-Simplify-document-savemessage_getnewheader.patch
0002-Factor-out-the-date-guessing-retrieving.patch
0003-Remove-convoluted-assert-statements.patch
0004-Implement-APPENDUID-support.patch

1: Just document and simplify the overengineered and ugly
   savemessage_getnewheader function as a prep work.
2: savemessage was too complex for my taste, and most of what it was
   doing was actually finding out a messages date. So I factored that
   out. Bonus points for later patches that convert the use of the
   rfc822 module which has been depreated since python 2.3 (!) to use
   the email module.
3: clean up some assert statements to not hide the working horses of
   that function.

4: the *real* patch that implements UIDPLUS. This saves us some work on
   capable mail servers, while we fall back to the old method of header
   insertion for mail servers without UIDPLUS extension.

I am running this code on my private mail account already :).

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20110121/b2245e12/attachment-0001.sig>