[PATCH 2/4] Re: Factor out the date guessing/retrieving

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Jan 24 19:00:00 GMT 2011

On Sun, Jan 23, 2011 at 05:58:40PM +0100, Sebastian Spaeth wrote:
> On Fri, 21 Jan 2011 22:43:02 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:

> In addition the wrong time could come from the rtime parameter, which in
> the maildir<->IMAP case is nothing else then the atime of the maildir
> file, I believe (not sure if that is actually a good thing to do or if
> that is even the case.). So the wrong time is not necessarily in the
> mail file.


> > >      def savemessage(self, uid, content, flags, rtime):
> > > +        """Save the message on the Server
> > > +
> > > +        This backend always assigns a new uid, so the uid arg is ignored.
> > 
> > Why ask for it, then?
> It is a function with that API defined in folder/Base.py and all
> backends (which derive from Base.py) override that function with
> whatever they should do in that case. Some backends take an UID and some
> don't. The comment was actually in the code of the function and was just
> moved by me to the documentation. :).So it makes sense to provide the
> same API to all backends.

Ah, true.

Patches 3 & 4 don't apply (since v2 of 1 & 2, I think). Could you please
rebase the whole topic on top of the current master?

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list