[PATCH] Re: folder/IMAP.py: accord __version__ with import

Nicolas Sebrecht nicolas.s-dev at laposte.net
Fri Jan 28 17:40:59 GMT 2011


On Fri, Jan 28, 2011 at 09:31:18AM +0100, Sebastian Spaeth wrote:
> On Thu, 27 Jan 2011 19:46:08 +0100, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > +* accord __version__ with import
> 
> Do we really need to put such a tiny internal change into the Changelog?
> It's not user visible at all and doesn't change any API either?

Right. Will change to "code cleanup".

> > -        headervalue += '-v' + offlineimap.__version__
> > +        headervalue += '-v' + __version__
> 
> This code is gone in patch 1/4 of my date refactoring/UIDPLUS series
> that I just mailed. So in case you want that series, this patch will not
> be needed anymore.
> 
> *BUT* this reminds me that I forgot to remove the __import__ in my patch
>  1/4, so we should probably do that as a followup patch.

It will be merged before because the current -rc is broken. I can't
release a stable version without such fix and the UIDPLUS topic will
have to wait for the stable to be merged.

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list